[dm-devel] Re: [PATCH] io-controller: implement per group request allocation limitation

Gui Jianfeng guijianfeng at cn.fujitsu.com
Tue Aug 4 06:41:13 UTC 2009



Munehiro Ikeda wrote:
> Gui Jianfeng wrote, on 07/09/2009 09:56 PM:
>> Hi Vivek,
>>
>> This patch exports a cgroup based per group request limits interface.
>> and removes the global one. Now we can use this interface to perform
>> different request allocation limitation for different groups.
>>
>> Signed-off-by: Gui Jianfeng<guijianfeng at cn.fujitsu.com>
>> ---
> (snip)
> 
> Hi Jianfeng,
> 
> If this helps.
> 
> If calling elv_io_group_congestion_threshold() before
> setting iog->iocg_id, iocg->nr_group_requests cannot be
> referred.  As a result of it, iog->nr_congestion_on is
> always misculculated as 0.
> This patch moves the calling of
> elv_io_group_congestion_threshold() after setting
> iog->iocg_id.
> 
> Signed-off-by: Munehiro "Muuhh" Ikeda <m-ikeda at ds.jp.nec.com>

  That's true, thanks.

-- 
Regards
Gui Jianfeng




More information about the dm-devel mailing list