Re: [dm-devel] [PATCH] dm table: improve terse warning messages with more context

[Alasdair G Kergon <agk redhat com>]

On Fri, Jul 31, 2009 at 12:25:24PM -0400, Mike Snitzer wrote:
> @@ -496,8 +500,13 @@ int dm_set_device_limits(struct dm_target *ti, struct dm_dev *dev,
>  	}
>  
>  	if (blk_stack_limits(limits, &q->limits, start << 9) < 0)
> -		DMWARN("%s: target device %s is misaligned",
> -		       dm_device_name(ti->table->md), bdevname(bdev, b));
> +		DMWARN("%s: target device %s is misaligned: "
> +		       "physical_block_size=%hu, alignment_offset=%hu, "
> +		       "start=%llu",
> +		       dm_device_name(ti->table->md), bdevname(bdev, b),
> +		       q->limits.physical_block_size,
> +		       q->limits.alignment_offset,
> +		       (unsigned long long) start << 9);
  
        unsigned int            physical_block_size;
        unsigned int            alignment_offset;

Presumably those should be just %u.

Alasdair