[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH v2] expose dm-stripe target's topology I/O hints



On Fri, Aug 21, 2009 at 10:17:18AM -0400, Mike Snitzer wrote:
> Add .io_hints to 'struct target_type' to allow the I/O hints portion of
> the 'struct queue_limits' to be set by each target.  Expose dm-stripe
> target's topology I/O hints.
 
Do you still think this should go into 2.6.31?
If so, please supply a revised patch header that explains the benefits
of having the patch (and reference the new stuff in 2.6.31 that it
uses).

> +	limits->io_opt = chunk_size * sc->stripes;

blk_queue_io_opt() ?

>  	.version = {1, 2, 0},

Ought to inc that too when adding a new fn.

> +		/* Set I/O hints portion of queue limits */

Where else are these called I/O hints or is this a new term to define
(or avoid)?

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]