[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] Re: [PATCH] Always pass result and sense on request completion



On Thu, 2009-12-10 at 10:49 +0100, Hannes Reinecke wrote:
> Hi James,
> 
> would you mind commenting on this patch?
> We really need this if we ever want to be able to do proper error code
> handling from multipath.

OK, not keen on the way you're setting req->errors.

Our big problem with FS requests is deferred or corrected errors
(basically we never want the FS to think we had a problem with them).  I
think it's currently OK because block tends to believe the returned
error code rather than req->errors ... I'd just hate it if that changed
and suddenly lots of stuff broke.

I think you're just looking for the sense data, so could you look at
that and not set req->errors?

James



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]