[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
[dm-devel] Re: [PATCH] scripts/checkpatch.pl: Change long line warning to 105 chars
- From: Paul Mundt <lethal linux-sh org>
- To: Joe Perches <joe perches com>
- Cc: Valdis Kletnieks vt edu, linux-kernel vger kernel org, dm-devel redhat com, Mikulas Patocka <mpatocka redhat com>, Andy Whitcroft <apw canonical com>, Andrew Morton <akpm linux-foundation org>, Linus Torvalds <torvalds linux-foundation org>, Alasdair G Kergon <agk redhat com>, Krzysztof Halasa <khc pm waw pl>
- Subject: [dm-devel] Re: [PATCH] scripts/checkpatch.pl: Change long line warning to 105 chars
- Date: Fri, 18 Dec 2009 14:57:12 +0900
On Thu, Dec 17, 2009 at 09:12:24PM -0800, Joe Perches wrote:
> On Thu, 2009-12-17 at 23:29 -0500, Valdis Kletnieks vt edu wrote:
> > Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non-
> > continuation line, it's probably in its rights to whinge.
> > grep -r -P '^\t{7:}(?!(.*,$|.*\);$))' . | more
> > produces a whole lot of "this can't end well" output.
>
> I think this is a good test to add to checkpatch.
>
> Add 105 character long line WARN test
> Add 80 character long line STRICT test
> Add 6+ leading indent tabs test, consider restructuring
>
This looks like a reasonable compromise.
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]