[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] Re: [PATCH] Drop 80-character limit in checkpatch.pl



Valdis Kletnieks vt edu writes:

> Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non-
> continuation line, it's probably in its rights to whinge.

Yes, but don't make it a hard error, only a suggestion that something is
probably really wrong.

> fs/reisersfs/do_balan.c, lines 460-477 (note: 3 leading tabs elided)
>
> 				leaf_paste_entries(&bi,
> 						   n +
> 						   item_pos
> 						   -
> 						   ret_val,
> 						   l_pos_in_item,
> 						   1,
> 						   (struct
> 						    reiserfs_de_head
> 						    *)
> 						   body,
> 						   body
> 						   +
> 						   DEH_SIZE,
> 						   tb->
> 						   insert_size
> 						   [0]
> 				    );
>
> Yes, that used to be 24 more columns to the right.  Gaak.

Precisely. It's a clear show of the damage hard rules like that do.
I can't even tell how the code should be fixed and if the simple merging
would do, since I can't really imagine how it would look like :-)
-- 
Krzysztof Halasa


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]