[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] dm: Fix alignment stacking on partitioned devices



>>>>> "Mike" == Mike Snitzer <snitzer redhat com> writes:

Mike> This is not required because DM assumes alignment_offset has
Mike> already been accounted for by the caller (e.g. LVM2 or some other
Mike> ficitional DM consumer).

Mike> Below, "start" represents the aligned start of the data for a
Mike> given volume.  That start must have already been shifted by
Mike> alignment_offset; as is the case with lvm2 (>= 2.02.51), see the
Mike> following lvm2 commits:
Mike> http://sources.redhat.com/git/gitweb.cgi?p=lvm2.git;a=commit;h=282029eb45e56
Mike> http://sources.redhat.com/git/gitweb.cgi?p=lvm2.git;a=commit;h=6c88b6c660020

Mike> All this being said, how did you arrive at this patch?  Why do you
Mike> feel it is needed?  Was it just from code inspection?

Interesting.

I have one case in my topology test scripts that prints a DM alignment
warning with the old stacking algorithm but doesn't with the new one.  A
bit surprising given that the new approach is much more picky.  MD
correctly prints a warning for the same device with both algorithms.

So I added a few printks and noticed that DM was calling the stacking
function with the same start sector for both devices.  That seemed odd
because the PV devices are misaligned partitions on the same disk.

Note that this was run using an old EL5 LVM toolkit because I'm not
interested in having userland compensate for any misalignment.

-- 
Martin K. Petersen	Oracle Linux Engineering


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]