[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] Patchwork and patch flow




On Feb 5, 2009, at 5:45 AM, Ryo Tsuruta wrote:

Hi Alasdair,

I'd also like to see more people visibly reviewing and testing patches. Please respond in the mailing list threads with comments and Reviewed-by: or Tested-by: lines as appropriate. If you've only reviewed part of the patch or only tested a subset of the cases you think need testing, explain in the thread but don't add those lines. Only offer a Reviewed-by line if you have performed a complete line-by-line review of the patch and patch header and
you support its inclusion in the tree.

To add a Tested-by tag, how much test do we actually need?
We've already done several tests of dm-ioband:
 Proportional I/O bandwidth controlling
 Loading/unloading driver and changing settings while under I/O load
 Bounds checking of setting parameters
 Benchmarks
Do you think these are enough for adding the tag?
It's very difficult for me to determine whether it's qualified or not.
It would be helpful if you could give me some advice.

Interesting question... If it was me, I'd like to see exactly what you wrote above. State that you tested it and how you tested it. If there are a number of people who test it and the things they describe offer a broad spectrum of tests, I think that's helpful. Also, if extra testing is wanted, it can be suggested based on what tests have been performed.

 brassow


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]