[dm-devel] Re: [PATCH] dm mpath: delay retry activate_path on SCSI_DH_RETRY

[Alasdair G Kergon <agk redhat com>]

On Tue, Feb 17, 2009 at 07:17:37PM +0530, Nikanth Karthikesan wrote:
> Delay retry to activate_path if it returns SCSI_DH_RETRY.
 
Please write a complete patch header if you'd like this queued for upstream!

E.g. Why?  Any cases where this will make matters worse or make no difference?

> +	unsigned long pg_init_jiffy;	/* To delay retry if SCSI_DH_RETRY */
> +#define SCSI_DH_RETRY_DELAY ((HZ * 2))
  
Why that particular value?
Please move it into a header file with an explanation of what it does.

Alasdair
-- 
agk redhat com