[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] dm-log: fix return value in create_log_context function



ACK.

 brassow

On Dec 18, 2008, at 3:23 PM, Takahiro Yasui wrote:

Hi Jon,

Thanks for reviewing this patch.

We might also want to change the message in that case then too,
right?  Maybe "Unable to create disk io client"?

Thanks, "create disk io client" is better. But I changed as
"couldn't create disk io client" for consistency with other
messages.

Regards,
---
Takahiro Yasui
Hitachi Computer Products (America) Inc.



When dm_io_client_create function fails in create_log_context function,
return value is set to r but it is not used. r should be returned.
In addition, the warning message is properly corrected so that it doesn't
indicate memory allocation.


Signed-off-by: Takahiro Yasui <tyasui redhat com>
---
drivers/md/dm-log.c |    4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6.28-rc8/drivers/md/dm-log.c
===================================================================
--- linux-2.6.28-rc8.orig/drivers/md/dm-log.c
+++ linux-2.6.28-rc8/drivers/md/dm-log.c
@@ -459,9 +459,9 @@ static int create_log_context(struct dm_
								   PAGE_SIZE));
		if (IS_ERR(lc->io_req.client)) {
			r = PTR_ERR(lc->io_req.client);
-			DMWARN("couldn't allocate disk io client");
+			DMWARN("couldn't create disk io client");
			kfree(lc);
-			return -ENOMEM;
+			return r;
		}

		lc->disk_header = vmalloc(buf_size);

--
dm-devel mailing list
dm-devel redhat com
https://www.redhat.com/mailman/listinfo/dm-devel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]