[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] dm: add topology support



>>>>> "Mike" == Mike Snitzer <snitzer redhat com> writes:

Mike,

+	if (blk_stack_limits(&ti->limits, &q->limits, 0) < 0)
+		DMWARN("%s: target device %s is misaligned",
+		       dm_device_name(ti->table->md), bdevname(bdev, b));

I did some testing tonight.  You're always passing offset 0 into the
stacking function so things are not working right.  This argument should
contain the offset to the first (data) sector.  So you want something
like get_start_sect(bdev) << 9 for the stacking to do its magic.

-- 
Martin K. Petersen	Oracle Linux Engineering


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]