Re: [dm-devel] [PATCH 2/2] dm: Add suspended check to multipath_message

[malahal us ibm com]

Mike Anderson [andmike linux vnet ibm com] wrote:
> Add suspended check to multipath_message
> 
> Signed-off-by: Mike Anderson <andmike linux vnet ibm com>
> ---
>  drivers/md/dm-mpath.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index 32d0b87..ee56ef7 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -1402,6 +1402,9 @@ static int multipath_message(struct dm_target *ti, unsigned argc, char **argv)
>  	struct multipath *m = (struct multipath *) ti->private;
>  	action_fn action;
> 
> +	if (dm_table_md_suspended(ti->table))
> +		return -EBUSY;

Same question as DELETING. SUSPEND bit could be set just after the above
check. Is it OK if the following code executes after the SUSPEND bit is
set???

> +
>  	if (argc == 1) {
>  		if (!strnicmp(argv[0], MESG_STR("queue_if_no_path")))
>  			return queue_if_no_path(m, 1, 0);
> 
> --
> dm-devel mailing list
> dm-devel redhat com
> https://www.redhat.com/mailman/listinfo/dm-devel