[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] dm-raid1 barriers



Mikulas Patocka [mpatocka redhat com] wrote:
> > > If this flush fails, the bits in memory are already clean and we don't 
> > > know which regions may hold unwritten data in the disk cache and which 
> > 
> > Actually we do: the on-disk version of the log tells us.
> 
> Yes, it could be read into another buffer and anded.
> 
> > > not. So, we must set all regions as dirty.
> >  
> > Anyway, let's not try to handle these situations at the moment.
> > what I need for now, is a way to know whether or not this situation has
> > actually occurred when we get reports from users, so probably a kernel
> > log message, a dm event raised plus a failure indicator against the device in
> > the status line.

Agreed, we don't want to handle this error case with reading the entries
from the disk log and comparing them with the in memory buffer at this
point.  Why not just set all regions to dirty as Mikulas pointed as a
short term solution? Not optimal but it is a correct way to handle.

--Malahal.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]