[dm-devel] Re: [PATCH 2/4] dm-snapshot-refactor-associations

Jonathan Brassow jbrassow at redhat.com
Thu Oct 8 21:14:03 UTC 2009


On Oct 8, 2009, at 12:32 PM, Mike Snitzer wrote:

> Jon,
>
> I discussed this with Mikulas and he agreed that the above would work.
> But he raised the fact that reverting dm-snapshot-refactor- 
> associations
> leaves the dm_snapshot and  dm_exception_store structures muddled with
> regard to where per-target members are located.  I'm inclined to agree
> with him.
>
> The dm-snapshot-refactor-associations patch offers cleanup so that:
> 1) dm_exception_store only contains exception store-specific members
> 2) dm_snapshot is the structure that contains per-target members
>
> So while this dm-snapshot-refactor-associations patch could be  
> viewed as
> "avoidable churn" it actually takes the data structures in a more
> controlled direction.
>
> I would rather dm-snapshot-refactor-associations be applied.

Ok, Mike.  Thanks for looking into it.

Reviewed-by: Jonathan Brassow <jbrassow at redhat.com>

  brassow




More information about the dm-devel mailing list