[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] shared snapshots




On Tue, 8 Sep 2009, Christoph Hellwig wrote:

> On Mon, Sep 07, 2009 at 11:15:18PM -0400, Mikulas Patocka wrote:
> > [ the previous message was eaten by mailing-list server, probably because 
> > it was too long, so I am reposting it without the patch. The patch is at 
> > the URL below. ]
> > 
> > Hi
> > 
> > This is patch for shared snapshots to be included in the next merge 
> > window. The patch only adds new modules dm_multisnapshot and 
> > dm_store_mikulas, it doesn't modify any existing code.
> 
> Not that I have anything against people advertising their names, but
> wouldn't a descriptive module name telling what this store is useful be
> better?

Well, I doubt it would be useful if someone renamed for example "xfs.ko" 
to "a_btree_based_journaled_filesystem.ko" --- and it would be less 
descriptive too because there are several other btree-based journaled 
filesystems.

Currently, there are two exception stores for these shared snapshots, they 
both use btrees and they have different format which has different pros 
and cons --- so I named them according to their designers, "mikulas" and 
"fujita-daniel". With what other names they should be differentiated?

Mikulas


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]