[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [dm-devel] [PATCH 2/5] virtio_blk: implement REQ_FLUSH/FUA support
- From: Christoph Hellwig <hch lst de>
- To: Tejun Heo <tj kernel org>
- Cc: tytso mit edu, linux-scsi vger kernel org, mst redhat com, jaxboe fusionio com, jack suse cz, rusty rustcorp com au, linux-kernel vger kernel org, swhiteho redhat com, linux-raid vger kernel org, linux-ide vger kernel org, dm-devel redhat com, James Bottomley suse de, Tejun Heo <tj kernle org>, konishi ryusuke lab ntt co jp, linux-fsdevel vger kernel org, vst vlnb net, rwheeler redhat com, hch lst de, chris mason oracle com
- Subject: Re: [dm-devel] [PATCH 2/5] virtio_blk: implement REQ_FLUSH/FUA support
- Date: Mon, 16 Aug 2010 20:33:17 +0200
On Mon, Aug 16, 2010 at 06:52:00PM +0200, Tejun Heo wrote:
> From: Tejun Heo <tj kernle org>
>
> Remove now unused REQ_HARDBARRIER support and implement REQ_FLUSH/FUA
> support instead. A new feature flag VIRTIO_BLK_F_FUA is added to
> indicate the support for FUA.
I'm not sure it's worth it. The pure REQ_FLUSH path works not and is
well tested with kvm/qemu. We can still easily add a FUA bit, and
even a pre-flush bit if the protocol roundtrips matter in real life
benchmarking.
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]