[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
[dm-devel] [RFC PATCH 3/3] block: improve detail in I/O error messages
- From: Mike Snitzer <snitzer redhat com>
- To: Hannes Reinecke <hare suse de>
- Cc: k-ueda ct jp nec com, michaelc cs wisc edu, tytso mit edu, sshtylyov mvista com, linux-scsi vger kernel org, jaxboe fusionio com, vst vlnb net, linux-kernel vger kernel org, hch lst de, linux-raid vger kernel org, linux-ide vger kernel org, dm-devel redhat com, James Bottomley suse de, konishi ryusuke lab ntt co jp, linux-fsdevel vger kernel org, jack suse cz, j-nomura ce jp nec com, rwheeler redhat com, swhiteho redhat com, chris mason oracle com, tj kernel org
- Subject: [dm-devel] [RFC PATCH 3/3] block: improve detail in I/O error messages
- Date: Tue, 7 Dec 2010 18:16:42 -0500
Classify severity of I/O errors for target and transport errors.
Signed-off-by: Mike Snitzer <snitzer redhat com>
---
block/blk-core.c | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 4ce953f..ab8c776 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2028,9 +2028,15 @@ bool blk_update_request(struct request *req, int error, unsigned int nr_bytes)
if (error && req->cmd_type == REQ_TYPE_FS &&
!(req->cmd_flags & REQ_QUIET)) {
- printk(KERN_ERR "end_request: I/O error, dev %s, sector %llu\n",
- req->rq_disk ? req->rq_disk->disk_name : "?",
- (unsigned long long)blk_rq_pos(req));
+ char *error_type = "I/O";
+
+ if (error == -ENOLINK)
+ error_type = "recoverable transport";
+ else if (error == -EREMOTEIO)
+ error_type = "critical target";
+ printk(KERN_ERR "end_request: %s error, dev %s, sector %llu\n",
+ error_type, req->rq_disk ? req->rq_disk->disk_name : "?",
+ (unsigned long long)blk_rq_pos(req));
}
blk_account_io_completion(req, nr_bytes);
--
1.7.2.3
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]