[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [Fwd: [PATCH] Latest git -master is not compilable]



The lock() macro is defined in libmultipath/lock.h and just invokes pthread_mutex_lock() so there'll be no problem replacing the call to lock() with a call to pthread_mutex_lock().

In the version I was patching (0.4.7) the macros were used everywhere, but in the latest git master it looks like pthread library calls are invoked directly. Please change it if it makes the style more consistent.

Regards,

Alex


Christophe Varoqui wrote:
Can you confirm the fix from Rumko does not break your ulibc setup ?



------------------------------------------------------------------------

Subject:
[PATCH] Latest git -master is not compilable
From:
Rumko <rumcic gmail com>
Date:
Fri, 5 Feb 2010 20:02:23 +0000
To:
"christophe varoqui opensvc com" <christophe varoqui opensvc com>

To:
"christophe varoqui opensvc com" <christophe varoqui opensvc com>


Hi!

In latest git -master on line 1443 of multipathd/main.c lock() is called on exit_mutex, but since exit_mutex is a pthread_mutex_t, pthread_mutex_lock() is needed.

Attached is the one-liner patch, tested it on a gentoo machine and seems to be working.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]