Re: [dm-devel] [PATCH] crypto/arc4: convert this stream cipher into a block cipher

[Herbert Xu <herbert gondor apana org au>]

On Sun, Feb 14, 2010 at 09:42:54PM +0100, Sebastian Andrzej Siewior wrote:
> * Sebastian Andrzej Siewior | 2010-02-12 09:42:28 [+0100]:
> 
> >+static void arc4_ivsetup(struct arc4_ctx *ctx, u8 *iv)
> > {
> >-	struct arc4_ctx *ctx = crypto_tfm_ctx(tfm);
> >+	if (unlikely(!ctx->new_key))
> 
> That should be likely(). Do you want me resend the whole thing? Haven't
> noticed anything else :)

How about we just remove it? It's not on a hot path anyway.

I can do this when integrating the patch so you don't have to
resend.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert gondor apana org au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt