[dm-devel] [PATCH 10 of 10] LVM: remove name restriction check for repair
Jonathan Brassow
jbrassow at redhat.com
Fri Feb 26 23:37:20 UTC 2010
Patch name: lvm-remove-name-restriction-check-for-repair.patch
I've removed the 'apply_lvname_restrictions' call in lvconvert if the
'--repair' option is given on the command line. This is because the
repair action will be making no new LV names; so the check shouldn't
be necessary. (Unless you don't like the idea of passing in hidden
LVs.)
Index: LVM2/tools/lvconvert.c
===================================================================
--- LVM2.orig/tools/lvconvert.c
+++ LVM2/tools/lvconvert.c
@@ -105,7 +105,12 @@ static int _lvconvert_name_params(struct
if ((ptr = strrchr(lp->lv_name_full, '/')))
lp->lv_name = ptr + 1;
- if (!apply_lvname_restrictions(lp->lv_name))
+ /*
+ * Repair will alter existing LVs - not make new ones - so
+ * it doesn't make sense to do name restriction tests.
+ */
+ if (!arg_count(cmd, repair_ARG) &&
+ !apply_lvname_restrictions(lp->lv_name))
return_0;
if (*pargc && lp->snapshot) {
More information about the dm-devel
mailing list