[dm-devel] [PATCH v2] dm: Fix alignment stacking on partitioned devices

Alasdair G Kergon agk at redhat.com
Tue Jan 5 18:04:12 UTC 2010


On Wed, Dec 23, 2009 at 01:07:20PM -0500, Mike Snitzer wrote:
> +	sector_t offset = (get_start_sect(bdev) + start) << 9;

Please can you fix the types here?

'offset' is defined as sector_t i.e. number of sectors, so 
shouldn't have '<< 9' which would make it bytes i.e. *not* sector_t.

Alasdair




More information about the dm-devel mailing list