[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH v2] dm: Fix alignment stacking on partitioned devices



On Wed, Dec 23, 2009 at 01:07:20PM -0500, Mike Snitzer wrote:
> +	if (blk_stack_limits(limits, &q->limits, offset) < 0)

extern int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
                            sector_t offset);

This function is asking for the offset to be supplied as sector_t i.e.
in units of sectors, but this patch uses bytes.  Please either change
that to sectors as per the prototype, or if it really does want bytes,
fix the prototype to make that clear.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]