[dm-devel] [PATCH] dm-mpath: Fixing unnecessary argument casting

Kiyoshi Ueda k-ueda at ct.jp.nec.com
Wed Jan 6 01:38:33 UTC 2010


Hi,

I have the exact same patch.

On 2010/01/06 3:39 +0900, Moger, Babu wrote:
> This patch removes couple of unnecessary argument casting. There is no functional change with this patch.
> Tested the changes with LSI storage..
> 
> CC: Chandra Seetharaman <chandra.seetharaman at us.ibm.com>
> Signed-off-by: Babu Moger <babu.moger at lsi.com>
> ---
> --- linux-2.6.33-rc2/drivers/md/dm-mpath.c.orig	2010-01-05 12:47:26.000000000 -0400
> +++ linux-2.6.33-rc2/drivers/md/dm-mpath.c	2010-01-05 12:34:00.000000000 -0400
> @@ -1128,8 +1128,7 @@ static int pg_init_limit_reached(struct
>  
>  static void pg_init_done(void *data, int errors)
>  {
> -	struct dm_path *path = data;
> -	struct pgpath *pgpath = path_to_pgpath(path);
> +	struct pgpath *pgpath = data;
>  	struct priority_group *pg = pgpath->pg;
>  	struct multipath *m = pg->m;
>  	unsigned long flags;
> @@ -1198,7 +1197,7 @@ static void activate_path(struct work_st
>  		container_of(work, struct pgpath, activate_path);
>  
>  	scsi_dh_activate(bdev_get_queue(pgpath->path.dev->bdev),
> -				pg_init_done, &pgpath->path);
> +				pg_init_done, pgpath);
>  }
>  
>  /*

Acked-by: Kiyoshi Ueda <k-ueda at ct.jp.nec.com>

Thanks,
Kiyoshi Ueda




More information about the dm-devel mailing list