Re: [dm-devel] [PATCH] optimize one of the cache flushes

[Alasdair G Kergon <agk redhat com>]

On Wed, Jul 07, 2010 at 06:22:24PM -0400, Mikulas Patocka wrote:
>  	if (!bio_empty_barrier(bio)) {
>  		__split_and_process_bio(md, bio);
> -		dm_flush(md);
> +		/*
> +		 * If the request isn't supported, don't waste time with
> +		 * the second flush.
> +		 */
> +		if (md->barrier_error != -EOPNOTSUPP)
> +			dm_flush(md);

Can we safely skip it with any other types of failures there too?
  
Alasdair