[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH v2] scsi: address leak in scsi_setup_discard_cmnd error path



On 07/07/10 21.44, Christoph Hellwig wrote:
>> Here is a minimalist patch that 1) removes the discard request's page
>> leak 2) preserves the prep cleanup rules covered above.  Fixing the leak
>> is a priority, introducing additional error path code sharing/cleanup is
>> secondary and can come later.
> 
> I much prefer this approach.

Same here, it's the correct layering. I'll queue this up, thanks.

-- 
Jens Axboe


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]