Re: [dm-devel] [PATCH 3/2] dm: table load must always try dm_setup_md_queue

[Kiyoshi Ueda <k-ueda ct jp nec com>]

Hi Mike,

On 06/05/2010 05:15 AM +0900, Mike Snitzer wrote:
> @@ -2164,7 +2164,8 @@ static int dm_init_request_based_queue(s
>  {
>  	struct request_queue *q = NULL;
>  
> -	BUG_ON(md->queue->elevator);
> +	if (unlikely(md->queue->elevator))
> +		return 1;

I think the "unlikely" should be rather "likely", since
dm_init_request_based_queue() is now called whenever request-based
table is loaded even after the actual initialization has been done.

For others,
Acked-by: Kiyoshi Ueda <k-ueda ct jp nec com>

Thanks,
Kiyoshi Ueda