Re: [dm-devel] [PATCH] dm_ioctl: Introduce DM_UEVENT_GENERATED_FLAG

[Peter Rajnoha <prajnoha redhat com>]

On 03/05/2010 08:38 PM, Alasdair G Kergon wrote:
> On Mon, Mar 01, 2010 at 09:27:17AM +0100, Peter Rajnoha wrote:
>> +	if (!dm_kobject_uevent(hc->md, KOBJ_CHANGE, cookie))
>> +		*flags |= DM_UEVENT_GENERATED_FLAG;
>   
> If userspace set this flag before the call, where is it cleared?
> It needs to have a defined state on *every* call.
> I'll add this to the top of validate_params.

Yes, you're right, we shouldn't rely on userspace to do this.
Indeed, it needs to be cleared directly. Thanks!

Peter