Re: [dm-devel] [PATCH 1/4] Iterate both origin and snapshot devices

[Mike Snitzer <snitzer redhat com>]

On Mon, Mar 15 2010 at  2:00am -0400,
Mikulas Patocka <mpatocka redhat com> wrote:

> Iterate both origin and snapshot devices
> 
> iterate_devices method should call the callback for all the devices where
> the bio may be remapped. Thus, snapshot_iterate_devices should call the callback
> for both snapshot and origin underlying devices because it remaps some bios
> to the snapshot and some to the origin.
> 
> snapshot_iterate_devices called the callback only for the origin device.
> This lead to badly calculated device limits if snapshot and origin were placed
> on different types of disks.
> 
> Signed-off-by: Mikulas Patocka <mpatocka redhat com>

Reviewed-by: Mike Snitzer <snitzer redhat com>