[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 1/3] Send KOBJ_ADD event after dm resume ioctl.



On Fri, Mar 19, 2010 at 12:01:23PM -0400, David Zeuthen wrote:
> > So again, the 'don't issue ADD until device is usable' offers a simple
> > way of avoiding this class of problems.
> But as Kay said it's a horrible horrible hack.
 
I quite agree.  But every solution is a horrible hack in some way.

If we *really* want to solve this, we have to put all options on the table
and go back to the fundamentals, and aim to get agreement on definitions
of things like "block device visible to userspace" which we all believe
can be made to work.

> Sorry, but this is an even worse hack. Mandating that all of user
> space (that is: past, present and future) needs to read some
> random 'private' attribute in sysfs because of weird life-cycle
> issues in the device-mapper implementation... that's not really
> workable.
 
I think it's a simple and general concept.  Similar to an inactive multipath
path that must not have any I/O sent to it unless the first path fails.
Similar to a device in a shared storage cluster that has an exclusive
reservation on it from a different node.

Basically it's a marker to say: 
  Hands off! There's nothing here that would interest you.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]