[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 2/9] blk: In elv_abort_queue skip requests with REQ_DONTPREP set

From: Jens Axboe <jens axboe oracle com>
To: Mike Anderson <andmike linux vnet ibm com>
Cc: dm-devel redhat com, James Bottomley <James Bottomley suse de>, linux-scsi vger kernel org
Subject: Re: [dm-devel] [PATCH 2/9] blk: In elv_abort_queue skip requests with REQ_DONTPREP set
Date: Tue, 4 May 2010 12:47:10 +0200

On Mon, May 03 2010, Mike Anderson wrote:
> Having REQ_DONTPREP set on a request can indicated that resources have been
> allocated for this request. In elv_abort_queue skip requests with
> REQ_DONTPREP set to avoid leaking resources.

This also seems weird, are you coding the API backwards from what SCSI
currently has implemented?

Would seem a lot cleaner to separate dont-prep from already-prepped.

-- 
Jens Axboe

Follow-Ups:
- Re: [dm-devel] [PATCH 2/9] blk: In elv_abort_queue skip requests with REQ_DONTPREP set
  - From: Mike Anderson

References:
- [dm-devel] [PATCH 0/9] blk: scsi: blk abort queue updates
  - From: Mike Anderson
- [dm-devel] [PATCH 2/9] blk: In elv_abort_queue skip requests with REQ_DONTPREP set
  - From: Mike Anderson

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]