[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
[dm-devel] [patch] md/dm-log: use PTR_ERR value instead of -ENOMEM
- From: Dan Carpenter <error27 gmail com>
- To: Neil Brown <neilb suse de>
- Cc: "Martin K. Petersen" <martin petersen oracle com>, Mike Snitzer <snitzer redhat com>, Nikanth Karthikesan <knikanth suse de>, linux-raid vger kernel org, dm-devel redhat com, Mikulas Patocka <mpatocka redhat com>, Alasdair G Kergon <agk redhat com>
- Subject: [dm-devel] [patch] md/dm-log: use PTR_ERR value instead of -ENOMEM
- Date: Sun, 16 May 2010 08:31:19 +0200
It's nicer to return the PTR_ERR() value instead of just returning
-ENOMEM. In the current code the PTR_ERR() value is always equal to
-ENOMEM so this doesn't actually affect anything, but still...
Signed-off-by: Dan Carpenter <error27 gmail com>
diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c
index 5a08be0..fbd80fb 100644
--- a/drivers/md/dm-log.c
+++ b/drivers/md/dm-log.c
@@ -455,7 +455,7 @@ static int create_log_context(struct dm_dirty_log *log, struct dm_target *ti,
r = PTR_ERR(lc->io_req.client);
DMWARN("couldn't allocate disk io client");
kfree(lc);
- return -ENOMEM;
+ return r;
}
lc->disk_header = vmalloc(buf_size);
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]