[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH v3 3/3] dm: lookup devices by path with name_to_dev_t



On Mon, May 24 2010 at  7:35pm -0400,
Mike Snitzer <snitzer redhat com> wrote:

> On Mon, May 24 2010 at 12:35pm -0400,
> Will Drewry <wad chromium org> wrote:
> 
> > On Mon, May 24, 2010 at 10:07 AM, Alasdair G Kergon <agk redhat com> wrote:
> > > On Mon, May 24, 2010 at 09:44:07AM -0500, Will Drewry wrote:
> > >> fwiw, the only reason for the copy was because |path| is a
> > >> const in the function but not when passed to name_to_dev_t.
> > >> I wasn't sure what the preferred practice was so I just duped
> > >> the data needed.
> > >
> > > Well check that it is treated as 'const' and send a separate patch to
> > > the maintainer to add const, perhaps?  If it isn't const (why would
> > > that be?), then yes we'd need to copy it.
> > 
> > I'll cross-check the code again and send a patch out if it looks like
> > it is const-safe.
> 
> Also, it would see that name_to_dev_t is EXPORT_SYMBOL?

Bleh, I typed that way too quick:
Also, it would seem that name_to_dev_t is _not_ EXPORT_SYMBOL?

Regards,
Mike


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]