[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [dm-devel] [PATCH v5] dm mpath: avoid call to blk_abort_queue by default
- From: Alasdair G Kergon <agk redhat com>
- To: Mike Snitzer <snitzer redhat com>
- Cc: dm-devel redhat com, Mike Anderson <andmike linux vnet ibm com>, Mike Christie <michaelc cs wisc edu>, linux-scsi vger kernel org
- Subject: Re: [dm-devel] [PATCH v5] dm mpath: avoid call to blk_abort_queue by default
- Date: Thu, 18 Nov 2010 20:18:41 +0000
On Thu, Nov 18, 2010 at 03:07:33PM -0500, Mike Snitzer wrote:
> It is expected that this race will be fixed in the near-term so it makes
> little since to remove all associated code. Providing control over the
> call to blk_abort_queue() facilitates continued testing and future
> flexibility to opt-in to lower latency path deactivation. Opting to
> enable this feature will emit a warning for the time being.
Ah, but then the *feature* keyword - which is only going to be needed
temporarily until it's fixed - becomes a permanent part of the interface...
If it's broken, let's just disable it (#define-style) until it gets fixed.
(And only if it doesn't get fixed in a reasonable amount of time, remove the
code.)
Alasdair
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]