[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [dm-devel] introduce dm-snap-mv
- From: Christoph Hellwig <hch lst de>
- To: Daniel Phillips <phillips phunq net>
- Cc: Cong Meng <mcpacino gmail com>, Nick Piggin <npiggin kernel dk>, linux-kernel vger kernel org, dm-devel redhat com, Alexander Viro <viro zeniv linux org uk>, linux-fsdevel vger kernel org, Andrew Morton <akpm linux-foundation org>, Christoph Hellwig <hch lst de>
- Subject: Re: [dm-devel] introduce dm-snap-mv
- Date: Fri, 8 Oct 2010 10:22:31 +0200
On Thu, Oct 07, 2010 at 02:31:14PM -0700, Daniel Phillips wrote:
> Hi Meng,
>
> The patch looks sensible, however the question is: why do you want to
> do this? Would it not be better to generalize your metadata format to
> accomodate the device's native blocksize?
Even if it uses fixed 4k sectors it should just read them in smaller
chunks OR even better stop using buffer heads and just read them
manually using submit_bio. BHs really shouldn't be used outside of
filesystems, and even there they slowly are on their way out.
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]