Re: [dm-devel] [PATCH] dm-thinp: report correct optimal I/O size

[Christoph Hellwig <hch infradead org>]

On Wed, Apr 27, 2011 at 06:25:25PM +0100, Joe Thornber wrote:
> tc->block_size is in sectors (you are passing sectors on the target
> line?).
> 
> What's probably happening here is we should be doing:
> 
> blk_limits_io_opt(limits, min(<some theoretical max>, tc->block_size << SECTOR_SHIFT));

Yes, that should do it.  I don't even think we need the max, the optimum
I/O size is a 32-bit value and we'll reach the limit of the possible
block sizes much earlier.