[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] Review of dm-block-manager.c



On Mon, Aug 01 2011 at  5:17pm -0400,
Mike Snitzer <snitzer redhat com> wrote:

> On Mon, Aug 01 2011 at  5:00pm -0400,
> Mikulas Patocka <mpatocka redhat com> wrote:
> 
> > Hi
> > 
> > This is review of dm-block-manager.c:
> > 
> > 
> > char buffer_cache_name[32];
> > sprintf(bm->buffer_cache_name, "dm_block_buffer-%d:%d",
> > --- it may not fit in 32 bytes.
> 
> It can accomodate nearly 1 trillion DM devices:
> 
> dm_block_buffer-253:9999999999

But more importantly, as agk pointed out to me, it will work with
maximum maj=2^12 min=2^20


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]