[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] convert dm-thin to use dm-bufio



On Fri, Aug 19, 2011 at 09:31:56AM -0400, Mikulas Patocka wrote:
> On Fri, 19 Aug 2011, Mike Snitzer wrote:
> > -struct dm_block;
> > +#define dm_block		dm_buffer
> > +#define dm_block_manager	dm_bufio_client
> > 
> > But I think it'd be best, in the long run, to have a follow-on patch
> > that does away with the aliases and just use the bufio structs
> > throughout the code.  Anyway, don't need to worry about this now.  But
> > what you've done is hack that should probably be cleaned up.
> 
> This way, it's easy to swap the original block manager and dm-bufio.
> 
> If I changed the names throughout the whole dm-thinp code, it would 
> conflict with any changes Joe may do.

I agree with Mikulas here.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]