[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] Fix over-zealous flush_disk when changing device size.



On Mon, 21 Feb 2011 14:36:01 -0500 Jeff Moyer <jmoyer redhat com> wrote:

> NeilBrown <neilb suse de> writes:
> 
> > -int __invalidate_device(struct block_device *bdev)
> > +int __invalidate_device2(struct block_device *bdev, bool kill_dirty)
> >  {
> >  	struct super_block *sb = get_super(bdev);
> >  	int res = 0;
> > @@ -1614,7 +1614,7 @@ int __invalidate_device(struct block_device *bdev)
> >  		 * hold).
> >  		 */
> >  		shrink_dcache_sb(sb);
> > -		res = invalidate_inodes(sb);
> > +		res = invalidate_inodes(sb, kill_dirty);
> >  		drop_super(sb);
> >  	}
> >  	invalidate_bdev(bdev);
> 
> Neil, I think you also need to change the EXPORT_SYMBOL from
> __invalidate_device to __invalidate_device2.  The floppy module won't
> build without that change.

Good point, thank.
I've just made this change in mt for-next tree so it should appear in -next
today?

NeilBrown


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]