[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] newbie question regarding target_type's map callback



Hello,

I designed a target where constructor sets split_io. During tests on
local filesystem (ext3) with dbench (150 processes, dbench is modified
that way it leaves its files at exit) (kernels: 2.6.33.7 and 2.6.39.1) i
noticed that amount of bios can reach level of 250k.

I was thinking that i can use "throttling" facility if i added following
section in my map function:

if (mytgt->inbox.pending > 180000) {
	wait_event_timeout(mytgt->throttling.wait, (mytgt->inbox.pending <
150000), 2 * HZ);
}

and 
if (mytgt->inbox.pending < 150000)
	wake_up_all(&mytgt->throttling.wait); 
in function which frees resources for given bio from "inbox".

I noticed that after adding this "throttling" feature it turned out that
filesystem is inconsistent after single test run (but throttling works
of course. inbox.pending never exceeds 180k + 3 .. 7, i guess it is
amount of logical cores).

Interesting is that without the facility filesystem and dm are
periodically stalled as long as my target confirms some number of
pending bios but filesystem corruption doesn't happen.

I was thinking that any "upper" bio which is split into bios of size not
bigger than split_io is completed only when all these small bios are
ended with bio_endio() thus changing order of small bios execution
(delaying some of them) doesn't matter.

Was i right ?
if i was then what could be reasons of corrupting filesystem because of
"throttling" feature?
or maybe i missed something, did i ?

I was thinking about these following also:
Can someone explain benefits from using map vs map_rq ?
Does DM_MAPIO_REQUEUE (map callback) work properly ? I noticed that dm
from 2.6.33.7 seems to not handle this right and filesystem complains on
IOs with error code.

Thanks for giving me clues on these above.

Regards,

-- 
Krzysztof Blaszkowski


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]