[dm-devel] dm: Integrity errors should not cause failover

[Mike Snitzer]

On Tue, Mar 08 2011 at  1:54am -0500,
Martin K. Petersen <martin.petersen at oracle.com> wrote:

> 
> Integrity errors need to be passed to the owner of the integrity
> metadata for processing. Consequently EILSEQ should be passed up the
> stack.
> 
> Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>

Acked-by: Mike Snitzer <snitzer at redhat.com>

Thanks Martin.  But James has already staged a few patches associated
with IO error differentation for 2.6.39.  Your dm-mpath patch will need
to be rebased on that work; best to feed it to James too.

(we were gambling that there wouldn't be additional DM or block changes
related to this work and figured it safe to have James carry all the
SCSI, block and DM changes... ;)

Problem is I'm not seeing a 2.6.39 branch in James' scsi-2.6-misc.git
(even though I know the changes are staged there ;)

See:
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=79775567e0439ca47eb9f501e52c4b713d44cf89
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=751b2a7d623ead9e55f751a6087efeab454b5659
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=63583cca745f440167bf27877182dc13e19d4bcf

James,
Any easy way to get Martin your 2.6.39 tree?  Do you have a branch (just
the tag isn't exposed)?

Mike

> ---
> 
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index f336c69..57f7dd3 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -1215,7 +1215,7 @@ static int do_end_io(struct multipath *m, struct request *clone,
>  	if (!error && !clone->errors)
>  		return 0;	/* I/O complete */
>  
> -	if (error == -EOPNOTSUPP)
> +	if (error == -EOPNOTSUPP || error == -EILSEQ)
>  		return error;
>  
>  	if (mpio->pgpath)
> 
> --
> dm-devel mailing list
> dm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel