[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] dm: Integrity errors should not cause failover



On Wed, May 18 2011 at 12:49am -0400,
Martin K. Petersen <martin petersen oracle com> wrote:

> 
> Integrity errors need to be passed to the owner of the integrity
> metadata for processing. Consequently EILSEQ should be passed up the
> stack.
> 
> Signed-off-by: Martin K. Petersen <martin petersen oracle com>
> Acked-by: Mike Snitzer <snitzer redhat com>
> 
> ---
> 
> Ping on this one?

It has been on my personal queue but I didn't push the issue with
Alasdair (for 2.6.39).

At this point seems we should be targetting this fix for 2.6.40 but I'll
defer to Alasdair on whether he'd like to push to .39 last minute.

> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index a550a05..aa4e570 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -1290,7 +1290,7 @@ static int do_end_io(struct multipath *m, struct request *clone,
>  	if (!error && !clone->errors)
>  		return 0;	/* I/O complete */
>  
> -	if (error == -EOPNOTSUPP || error == -EREMOTEIO)
> +	if (error == -EOPNOTSUPP || error == -EREMOTEIO || error == -EILSEQ)
>  		return error;
>  
>  	if (mpio->pgpath)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]