[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [RESEND][PATCH 4/4] scsi_dh: code cleanup and remove the references to scsi_dev_info



On Thu, Nov 03 2011 at 11:52am -0400,
Moger, Babu <Babu Moger netapp com> wrote:

> All the handlers have implemented the match function(look at patch 1, 2, 3).
> We don't need to use scsi_dev_info any more for matching purposes.
> Cleaning up the scsi_dh code.
> 
> FYI..
> Match function was originally implemented by this 
> 
> http://www.spinics.net/lists/linux-scsi/msg54284.html
> or
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=6c3633d08acf514e2e89aa95d2346ce9d64d719a
> 
> Signed-off-by: Babu Moger <babu moger netapp com>

Looks good, effectively reverts commit 940d7faa481

But SCSI_DEVINFO_DH can be removed too:

diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h
index a6ebf4c..1fbf7c7 100644
--- a/drivers/scsi/scsi_priv.h
+++ b/drivers/scsi/scsi_priv.h
@@ -44,7 +44,6 @@ static inline void scsi_log_completion(struct scsi_cmnd *cmd, int disposition)
 enum {
 	SCSI_DEVINFO_GLOBAL = 0,
 	SCSI_DEVINFO_SPI,
-	SCSI_DEVINFO_DH,
 };
 
 extern int scsi_get_device_flags(struct scsi_device *sdev,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]