Re: [dm-devel] dm-bufio

[Joe Thornber <thornber redhat com>]

On Thu, Oct 13, 2011 at 06:31:47PM -0400, Mike Snitzer wrote:
> On Thu, Oct 13 2011 at  6:19pm -0400,
> Mikulas Patocka <mpatocka redhat com> wrote:
> 
> > > +static int dm_bufio_trylock(struct dm_bufio_client *c)
> > > +{
> > > +	return dm_bufio_trylock(c);
> > > +}
> > > +
> > > +static void dm_bufio_unlock(struct dm_bufio_client *c)
> > > +{
> > > +	dm_bufio_unlock(c);
> > > +}
> > 
> > These two functions are recursive nonsense :) There should be
> > "return mutex_trylock(&c->lock);" and "mutex_unlock(&c->lock);".
> 
> Heheh.  Sorry, M-x replace-string gone wild.
> 
> Here is a fixed version.

Thanks Mike.  If you haven't tested something can you please say, so I
know to run it through the full suite?

- Joe