[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] dm-bufio



On Mon, Oct 17, 2011 at 12:49:22PM -0400, Mikulas Patocka wrote:
> If you want to do it, just do it, but it makes no sense to me.

Well Alasdair, Mike and myself have all looked at this code at various
times over the last 18 months and come to similar conclusions.  We
find the following logic difficult with all those gotos.  There is
also some redundancy which I only noticed when trying to refactor it
(repeated checks).  There's an example that has a jump from one branch
of an 'if' to another, it's trivial to factor out into a function for
each branch, yet you insist on arguing and refuse to change it.  I'm
perfectly prepared to accept that you're familiar enough with this
code, or just clever enough for it to be transparent to you.  But it's
the sort of thing that's going to get picked up on by other small
brained developers like me.  Choose your battles wisely, and save your
energies for something more interesting.

- Joe


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]