[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [dm-devel] [PATCH] multipath: strdup multipath alias, so that it isn't deleted.
- From: Christophe Varoqui <christophe varoqui gmail com>
- To: Benjamin Marzinski <bmarzins redhat com>
- Cc: device-mapper development <dm-devel redhat com>, Christophe Varoqui <christophe varoqui gmail com>
- Subject: Re: [dm-devel] [PATCH] multipath: strdup multipath alias, so that it isn't deleted.
- Date: Thu, 01 Sep 2011 08:55:18 +0200
On mer., 2011-08-31 at 21:45 -0500, Benjamin Marzinski wrote:
> When a multipath device is added to multipathd with ev_add_map(),
> > the alias is not duplicated, and is freed immediately after
> ev_add_map()
> > returns, causing a memory error. This patch corrects that.
> >
Merged.
Do you think the "mpp->alias = NULL" is still necessary in the following
setup_multipath() error code path ? alias is set to NULL by
free_multipath() these days ...
> if (setup_multipath(vecs, mpp)) {
> mpp->alias = NULL; <========
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]