Re: [dm-devel] [PATCH] scsi_dh_rdac: Add dynamic match functionality to rdac handler

[Mike Christie <michaelc cs wisc edu>]

On 04/10/2012 12:06 PM, Moger, Babu wrote:
> This patch adds the dynamic match functionality to scsi_dh_rdac driver.
> New vendor and product strings are normally not there in the kernel. Whenever
> the new product is tested with this driver we see failures during the disco-
> very. Without the handler attached, the default scsi mid-level retries would
> take effect for certain check-conditions. Default retries(5) are not enough in
> some cases(especially with large configuration or huge lun cases).
> 
> This patch will send an inquiry if the vendor/product strings are not in the
> device list and match with vendor signature.
> 
> Signed-off-by: Babu Moger <babu moger netapp com>
> Reviewed-by: Somasundaram Krishnasamy <Somasundaram Krishnasamy netapp com>
> ---
> 
> --- linux-3.4-rc2/drivers/scsi/device_handler/scsi_dh_rdac.c.orig	2012-04-07 20:30:41.000000000 -0500
> +++ linux-3.4-rc2/drivers/scsi/device_handler/scsi_dh_rdac.c	2012-04-10 10:48:40.000000000 -0500
> @@ -818,7 +818,10 @@ static const struct scsi_dh_devlist rdac
>  
>  static bool rdac_match(struct scsi_device *sdev)
>  {
> -	int i;
> +	int i, err;
> +	struct c8_inquiry inqp;

The per function stack use limit is 512 bytes right? If so then the
patch seems ok to me (thought maybe the c8_inquiry was too large but it
is under that 512 limit), so:

Reviewed-by: Mike Christie <michaelc cs wisc edu>