[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [dm-devel] [PATCH v5 12/12] block: Only clone bio vecs that are in use
- From: Tejun Heo <tj kernel org>
- To: Mikulas Patocka <mpatocka redhat com>
- Cc: axboe kernel dk, Kent Overstreet <koverstreet google com>, linux-bcache vger kernel org, linux-kernel vger kernel org, device-mapper development <dm-devel redhat com>, agk redhat com, sage newdream net, yehuda hq newdream net, vgoyal redhat com, drbd-dev lists linbit com
- Subject: Re: [dm-devel] [PATCH v5 12/12] block: Only clone bio vecs that are in use
- Date: Wed, 8 Aug 2012 16:28:04 -0700
On Mon, Aug 06, 2012 at 07:16:33PM -0400, Mikulas Patocka wrote:
> Hi Kent
>
> When you change the semantics of an exported function, rename that
> function. There may be external modules that use __bio_clone and this
> change could silently introduce bugs in them.
>
> Otherwise, the patchset looks fine.
I don't know. This doesn't change the main functionality and should
be transparent unless the caller is doing something crazy. It *might*
be nice to rename but I don't think that's a must here.
Thanks.
--
tejun
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]