[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] workqueues and percpu (was: [PATCH] dm: remake of the verity target)



Hello,

On Fri, Mar 09, 2012 at 02:06:23PM -0800, Mandeep Singh Baines wrote:
> > I think the right thing to do for now is to add cpu hotplug notifier
> > and do flush_work_sync() on the work item.  We can later move that
> > logic into workqueue and remove it from crypto.
> > 
> 
> That seems like the correct solution. I will implement that.

So, I've been looking at it and now am not so sure whether moving it
to workqueue core is necessary.  With the proposed workqueue updates,
workqueue's behavior is now closely aligned with the timer which also
considers the specified affinity overridable (to avoid reentrancy and
during CPU offlining) and I don't think it's reasonable to require
users which need strict affinity to implement proper CPU up/down
notifiers - in many cases, they need them anyway.  I'll try to review
the current users and think more about it.

Thanks.

-- 
tejun


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]