[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [dm-devel] [PATCH v6 04/13] pktcdvd: Switch to bio_kmalloc()
- From: Tejun Heo <tj kernel org>
- To: Kent Overstreet <koverstreet google com>
- Cc: dm-devel redhat com, Peter Osterlund <petero2 telia com>, Jiri Kosina <jkosina suse cz>, linux-kernel vger kernel org, linux-bcache vger kernel org, mpatocka redhat com, bharrosh panasas com, vgoyal redhat com
- Subject: Re: [dm-devel] [PATCH v6 04/13] pktcdvd: Switch to bio_kmalloc()
- Date: Wed, 22 Aug 2012 12:55:46 -0700
(cc'ing Jiri, hi!)
On Wed, Aug 22, 2012 at 10:04:01AM -0700, Kent Overstreet wrote:
> This is prep work for killing bi_destructor - previously, pktcdvd had
> its own pkt_bio_alloc which was basically duplication bio_kmalloc(),
> necessitating its own bi_destructor implementation.
>
> v5: Un-reorder some functions, to make the patch easier to review
>
> Signed-off-by: Kent Overstreet <koverstreet google com>
> CC: Peter Osterlund <petero2 telia com>
Apart from bio_reset() not resetting bi_end_io and bi_private, this
looks fine to me but lack of testing makes me a bit hesitant to ack
it.
Peter doesn't want to be the maintainer of pktcdvd anymore. Maybe
Jiri can be tricked into taking this one too? :)
Thanks.
--
tejun
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]