[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH v6 05/13] block: Kill bi_destructor



Hello,

On Wed, Aug 22, 2012 at 10:04:02AM -0700, Kent Overstreet wrote:
> +#define BIO_KMALLOC_POOL NULL

I would much prefer just doing

	if (!bs) {
		/* do kmalloc/kfree thing */
	} else {
		/* do bioset thing */
	}

NULL @bs indicating no bioset is perfectly natural and so is using
generic memory allocation in the absense of bioset.  I don't see any
value in defining Bio_KMALLOC_POOL to be NULL.

Thanks.

-- 
tejun


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]